Rebase: Add worker-loader#867
Merged
developit merged 10 commits intodevelopit:masterfrom Oct 6, 2021
marcbouchenoire:feat/syntax-worker-detection
Merged
Rebase: Add worker-loader#867developit merged 10 commits intodevelopit:masterfrom marcbouchenoire:feat/syntax-worker-detection
developit merged 10 commits intodevelopit:masterfrom
marcbouchenoire:feat/syntax-worker-detection
Conversation
Targets enhancement: #170 Enable usage of `microbundle --worker-loader` to apply rollup-plugin-web-worker-loader. Allow bundling web workers automatically - Add flag `--worker-loader` - For format `es` and `modern`, a Worker `type: module` is automatically bundled
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 30242dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Thanks for taking care of attribution <3 |
developit
approved these changes
Oct 6, 2021
Owner
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
This looks good to me! It would be nice to find an output mode that works with CJS, though I know that's something rollup-plugin-off-main-thread specifically throws an error for.
Merged
This was referenced Oct 6, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: This PR is a fork of #815 from @TimDaub. I asked @developit if I could help unblock it by rebasing and fixing the last few remaining conflicts myself and this is it. After rebasing, I've also manually rewritten the commit history to ensure @TimDaub stays the author of all commits.