Skip to content

Fixed grammatical errors and the like.#178

Closed
gchang12 wants to merge 3 commits intojava:mainfrom
gchang12:fix_getting-started
Closed

Fixed grammatical errors and the like.#178
gchang12 wants to merge 3 commits intojava:mainfrom
gchang12:fix_getting-started

Conversation

@gchang12
Copy link

@gchang12 gchang12 commented Oct 14, 2025

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 14, 2025
@ammbra ammbra self-requested a review October 15, 2025 12:48
ammbra
ammbra approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

danthe1st
danthe1st reviewed Oct 15, 2025
View reviewed changes
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md Outdated
Copy link
Contributor

@danthe1st danthe1st Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the idea of using a masked link here. Having the full link shown as text comes with the advantage that users could see the link directly without having to hover over or click it.

Copy link
Author

@gchang12 gchang12 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Copy link
Author

@gchang12 gchang12 Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been fixed.

2e3d50e
d5f0204

@gchang12
Update 01_getting-started-with-java.md
2e3d50e 
Reverted changes on Line 97
@gchang12
Update 01_getting-started-with-java.md
d5f0204 
Replace second sentence with revised version from original commit.
@gchang12 gchang12 closed this by deleting the head repository Oct 25, 2025
@danthe1st
Copy link
Contributor

danthe1st commented Oct 25, 2025

@gchang12 Was it your intention to close this PR when you deleted your fork?

@gchang12
Copy link
Author

gchang12 commented Oct 25, 2025

@gchang12 Was it your intention to close this PR when you deleted your fork?

Sorry. It must have been closed automatically. This was not my intention, in any case.

@danthe1st
Copy link
Contributor

danthe1st commented Oct 25, 2025 •
edited
Loading

If you still want to contribute that change, I think you'd have to open a new PR (and not delete your fork/branch until it's merged).

@gchang12
Copy link
Author

gchang12 commented Oct 25, 2025

If you still want to contribute that change, I think you'd have to open a new PR (and not delete your fork/branch until it's merged).

Thank you for the tip. I'll do just that.

gchang12 added a commit to gchang12/devjava-content that referenced this pull request Oct 27, 2025
@gchang12
Recreated changes introduced in now-invalid PR.
77b230c 
java#178 (comment)
@gchang12 gchang12 mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammbra ammbra ammbra approved these changes

+1 more reviewer

@danthe1st danthe1st danthe1st left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gchang12 @danthe1st @ammbra

Comments