Skip to content

Fix language in section 01 01 01#179

Open
gchang12 wants to merge 7 commits intojava:mainfrom
gchang12:fix-language-in-section_01-01-01
Open

Fix language in section 01 01 01#179
gchang12 wants to merge 7 commits intojava:mainfrom
gchang12:fix-language-in-section_01-01-01

Conversation

@gchang12
Copy link

Redid the edits introduced in #178 (comment)

Corrected grammar and made a few more edits, including but not limited to:

  • replacing 'expand' with 'extract' where appropriate.
  • enclosing function names within backticks.
  • inserting commas where appropriate
  • inserting key-names inside angle-brackets

TODO: Inspect for missing resources marked by <!-- NOTE:

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 27, 2025
Copy link
Contributor

@danthe1st danthe1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that I am not a maintainer and I'm not working at Oracle. I don't have any authority here. What I'm writing here are merely suggestions and what you need to change is to be decided by the maintainers.

That being said, this PR might be a good chance to also change the article to install/use JDK 25 instead of JDK 19 (As Oracle designated JDK 25 to be an LTS, that's also what people would be more likely to use I guess).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically that's outdated with JDK 22 (which allows running multi-file programs like that) but I am not sure about the best way to say that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this?

df3fbc2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the <!-- NOTE: Missing hyperlink --> is here by mistake.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a placeholder. I meant to put in the hyperlink to that article, but I wasn't able to find it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change introduced in this commit should fix this.

c62bb7f

I also removed the '19' to avoid the need to change this in the future.


#### Error Messages on Microsoft Windows Systems

<!-- NOTE: What error? -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems to be a leftover that should be addressed before merging as well.

Copy link
Author

@gchang12 gchang12 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further below, on line 421, there's this paragraph:

If you receive this error, java cannot find your bytecode file, HelloWorldApp.class.

There's no previous codeblock containing the error in question.

Incorporated suggestions from review by danthe1st
Mentioned multi-file program execution-from-command-line feature introduced in JDK 22.
Inserted hyperlink to article explaining how to update PATH variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments