Conversation
PeterDaveHello
left a comment
PeterDaveHello
left a comment
There was a problem hiding this comment.
Would you please also mention that some new keys are added, in the commit message and PR subject? It'll make the change history more accurate and clear, thanks.
| DD8F2338BAE7501E3DD5AC78C273792F7D83545D | ||
| A48C2BEE680E841632CD4E44F07496B3EB3C1762 | ||
| B9E2F5981AA6E0CD28160D9FF13993A75599653C | ||
| C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C |
There was a problem hiding this comment.
Not sure the reason to change the order here 🤔
There was a problem hiding this comment.
It might make it easier to keep in sync with the list of keys in https://github.com/nodejs/node/#release-keys (where it's ordered by the name of the releaser the key belongs to).
There was a problem hiding this comment.
Should be some script ideally that dumps from that repo, sorts and inserts somewhere in this repo for consumption
|
@PeterDaveHello there are no keys added, the new lines are from sorting them to match the upstream source Removed:
|
|
@nschonni you're right, just misunderstood because of the ordering, maybe can also mention that the next time ;) |
Node.js release keys were also updated, see nodejs#1291 nodejs#1290 - https://nodejs.org/en/blog/release/v14.7.0/ - https://github.com/nodejs/node/releases/tag/v14.7.0 - https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.7.0
4 participants
Since the images that would need these old keys are out of support, we should be able to drop them now to shrink the generated Dockerfiles a little.
I just copied the current ordering from https://github.com/nodejs/node/#release-keys along with @richardlau new key that is being PR'd to that file right now