Add update-keys.sh for nodejs release keys update#1297
Merged
PeterDaveHello merged 1 commit intonodejs:masterfrom Jul 23, 2020
Merged
Add update-keys.sh for nodejs release keys update#1297PeterDaveHello merged 1 commit intonodejs:masterfrom
PeterDaveHello merged 1 commit intonodejs:masterfrom
Conversation
SimenB
approved these changes
Jul 22, 2020
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Would be great if it was a separate file rather than crawling the readme. Nice to have a script, tho!
nschonni
approved these changes
Jul 22, 2020
Member
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
Don't know awk well enough, but this looks right
PeterDaveHello
force-pushed
the
add-update-keys-script
branch
from
e551649 to
ae84d3f
Compare
PeterDaveHello
force-pushed
the
add-update-keys-script
branch
from
ae84d3f to
db2fe72
Compare
Member
Author
|
@nodejs/docker I did a few minor changes, please help take a look, thanks! |
nschonni
approved these changes
Jul 22, 2020
Member
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
LGTM. It may be worth making the keys a version specific file and pull from the individual branches later
SimenB
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #1291