build: run Windows CI only on nondeprecated build configurations#1152
build: run Windows CI only on nondeprecated build configurations#1152mhdawson merged 1 commit intonodejs:mainfrom
Conversation
The windows-2016 runner has been deprecated on March 15, 2022. That is why those runs are getting cancelled recently. This change fixes the issue by removing that runner from the config. Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022 Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
changed the title
|
@RaisinTen thanks for the change. @richardlau I think you dealt with a similar issue in other tests. Can you remind me how you handled that. Just want to confirm removing is the way we want to go. |
For Node.js core we had Node.js 12 being tested on "windows-2016" and nothing else for which I bumped that to "windows-2019" (nodejs/node#42349). Node.js 14 was using "windows-latest" and I had to pin that to "windows-2019" (nodejs/node#42350) as Node.js 14 currently cannot detect Visual Studio 2022. Neither of those cases appear to apply here, so this change LGTM. |
|
@RaisinTen thanks for fixing this up :) |
3 participants
The windows-2016 runner has been deprecated on March 15, 2022. That is
why those runs are getting cancelled recently. This change fixes the
issue by removing that runner from the config.
Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @mhdawson