[v12.x] build: pin Windows GitHub runner to windows-2019 by richardlau · Pull Request #42349 · nodejs/node

richardlau · 2022-03-15T18:19:33Z

GitHub is removing the Windows 2016 runner image on March 15, 2022.

Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/

March 15, 2022 is today 😰. They're not gone yet -- #42348 is running on them, but we'll need to move.

nodejs-github-bot · 2022-03-15T18:19:37Z

Review requested:

@nodejs/actions

richardlau · 2022-03-15T18:24:10Z

Hmm, that didn't work https://github.com/nodejs/node/runs/5558888762?check_suite_focus=true 😞
It looked like Node.js 12 should be able to build with VS 2019:

node/vcbuild.bat

Lines 295 to 311 in 3901891

    
           @rem check if VS2019 is already setup, and for the requested arch 
        
           if "_%VisualStudioVersion%_" == "_16.0_" if "_%VSCMD_ARG_TGT_ARCH%_"=="_%target_arch%_" goto found_vs2019 
        
           @rem need to clear VSINSTALLDIR for vcvarsall to work as expected 
        
           set "VSINSTALLDIR=" 
        
           @rem prevent VsDevCmd.bat from changing the current working directory 
        
           set "VSCMD_START_DIR=%CD%" 
        
           set vcvars_call="%VCINSTALLDIR%\Auxiliary\Build\vcvarsall.bat" %vcvarsall_arg% 
        
           echo calling: %vcvars_call% 
        
           call %vcvars_call% 
        
           if errorlevel 1 goto msbuild-not-found 
        
           if defined DEBUG_HELPER @ECHO ON 
        
           :found_vs2019 
        
           echo Found MSVS version %VisualStudioVersion% 
        
           set GYP_MSVS_VERSION=2019 
        
           set PLATFORM_TOOLSET=v142 
        
           goto msbuild-found

If Visual Studio 2017 is not found, attempt to find Visual Studio 2019.

GitHub is removing the Windows 2016 runner image on March 15, 2022. Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/

richardlau · 2022-03-15T19:55:01Z

Hmm, that didn't work https://github.com/nodejs/node/runs/5558888762?check_suite_focus=true 😞

Needed to change

node/vcbuild.bat

Line 247 in 3901891

if "_%VCINSTALLDIR%_" == "__" goto msbuild-not-found

so that it searches for VS2019 when it fails to find VS2017: 94956e0

nodejs-github-bot · 2022-03-15T20:14:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43057/

richardlau · 2022-03-15T20:32:41Z

cc @nodejs/platform-windows @nodejs/build-files

richardlau · 2022-03-15T20:52:48Z

Fast-track has been requested by @richardlau. Please 👍 to approve.

nodejs-github-bot · 2022-03-15T21:14:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43058/

Mesteery · 2022-03-16T14:49:51Z

I'm not sure if the fast-track label/comment thing works for v12.x.

I don't think it's normal that it doesn't work.

By the way, I have modified your message so that there are no problems with ncu.

aduh95 · 2022-03-16T14:54:13Z

I'm not sure if the fast-track label/comment thing works for v12.x.

I don't think it's normal that it doesn't work.

I think it is, the workflow hasn't been backported to v12.x-staging: https://github.com/nodejs/node/tree/v12.x-staging/.github/workflows

Mesteery · 2022-03-16T14:58:51Z

Oh right, I thought it was the workflows of the main branch that took precedence.

If Visual Studio 2017 is not found, attempt to find Visual Studio 2019. PR-URL: #42349 Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/ Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

GitHub is removing the Windows 2016 runner image on March 15, 2022. Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/ PR-URL: #42349 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

richardlau · 2022-03-16T15:33:35Z

Landed in 4ee4490...a64a3ca.

If Visual Studio 2017 is not found, attempt to find Visual Studio 2019. PR-URL: #42349 Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/ Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

GitHub is removing the Windows 2016 runner image on March 15, 2022. Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/ PR-URL: #42349 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

github-actions bot added meta Issues and PRs related to the general management of the project. v12.x labels Mar 15, 2022

Mesteery approved these changes Mar 15, 2022

View reviewed changes

richardlau added 2 commits March 15, 2022 15:40

build: fix detection of Visual Studio 2019

94956e0

If Visual Studio 2017 is not found, attempt to find Visual Studio 2019.

build: pin Windows GitHub runner to windows-2019

729251b

GitHub is removing the Windows 2016 runner image on March 15, 2022. Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/

richardlau force-pushed the workflow-v12.x branch from 8507a16 to 729251b Compare March 15, 2022 19:45

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022

richardlau added the fast-track PRs that do not need to wait for 72 hours to land. label Mar 15, 2022

lpinca approved these changes Mar 15, 2022

View reviewed changes

richardlau added fast-track PRs that do not need to wait for 72 hours to land. and removed fast-track PRs that do not need to wait for 72 hours to land. labels Mar 15, 2022

tniessen approved these changes Mar 15, 2022

View reviewed changes

targos approved these changes Mar 15, 2022

View reviewed changes

aduh95 approved these changes Mar 15, 2022

View reviewed changes

github-actions bot mentioned this pull request Mar 16, 2022

CI Reliability 2022-03-16 nodejs/reliability#222

Open

29 tasks

richardlau closed this Mar 16, 2022

richardlau deleted the workflow-v12.x branch March 16, 2022 15:33

richardlau mentioned this pull request Mar 16, 2022

v12.22.11 proposal #42363

Merged

richardlau mentioned this pull request Mar 21, 2022

build: run Windows CI only on nondeprecated build configurations nodejs/node-addon-api#1152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[v12.x] build: pin Windows GitHub runner to windows-2019#42349

[v12.x] build: pin Windows GitHub runner to windows-2019#42349
richardlau wants to merge 2 commits intonodejs:v12.x-stagingfrom
richardlau:workflow-v12.x

richardlau commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022 •

edited by Mesteery

Loading

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

Mesteery commented Mar 16, 2022 •

edited

Loading

Uh oh!

aduh95 commented Mar 16, 2022

Uh oh!

Mesteery commented Mar 16, 2022

Uh oh!

richardlau commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

richardlau commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022 • edited by Mesteery Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

Mesteery commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented Mar 16, 2022

Uh oh!

Mesteery commented Mar 16, 2022

Uh oh!

richardlau commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

richardlau commented Mar 15, 2022 •

edited by Mesteery

Loading

Mesteery commented Mar 16, 2022 •

edited

Loading