Skip to content

Now returning correct experiment key without version#581

Closed
aakashtiwari wants to merge 1 commit intosplitrb:masterfrom
aakashtiwari:hotfix/bug-in-key-without-version-method
Closed

Now returning correct experiment key without version#581
aakashtiwari wants to merge 1 commit intosplitrb:masterfrom
aakashtiwari:hotfix/bug-in-key-without-version-method

Conversation

@aakashtiwari
Copy link

Here I am splitting key based on colon i.e. ":". If it is an experiment finished key it will be have array length greater than 2, and method will be return the key as it is. Else it will remove the version number and return the experiment name.

@andrehjr
Copy link
Member

Thanks so much for the PR @aakashtiwari <3 Although, digging deeper into this issue I ended up fixing it on a different way with #582 without the need of changing key_without_version.

The issue was that active_experiments should not be loop on all user.keys. As you noted, the current impl of key_without_version does not work with ':finished' keys here.

Causing conflict and overriding the value of the experiment with the finished value. Which is always true.

@andrehjr andrehjr closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants