Skip to content

When loading active_experiments, it should not look into user's 'finished' keys#582

Merged
andrehjr merged 1 commit intomasterfrom
fix-active-experiments-without-finished-keys
Aug 26, 2019
Merged

When loading active_experiments, it should not look into user's 'finished' keys#582
andrehjr merged 1 commit intomasterfrom
fix-active-experiments-without-finished-keys

Conversation

@andrehjr
Copy link
Member

Fixes #580

All calls for experiments keys on User should be gated with keys_without_finished. This method filters out all 'finished' keys.

The issue happened because active_experiments was loading all user.keys. And when calling key_without_version method with a 'finished' key with more than 9 versions. Example:

irb(main):012:0> key_without_version('exp:11:finished')
=> "exp"
irb(main):013:0> key_without_version('exp:1:finished')
=> "exp:1:finished"

It would end up overriding the value of an experiment with the 'exp:11:finished' value from the Storage, which is always 'true'.

@andrehjr andrehjr merged commit db07b1c into master Aug 26, 2019
@andrehjr andrehjr deleted the fix-active-experiments-without-finished-keys branch August 26, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting active experiment value equal to value of active experiments finished key value(i.e. true, once the experiment is finished) )

1 participant